Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Implement replacement functions for tls_private_key and tls_self_signed_certificate test configuration resources #10024

Merged
merged 3 commits into from
Sep 27, 2019
Merged

provider: Implement replacement functions for tls_private_key and tls_self_signed_certificate test configuration resources #10024

merged 3 commits into from
Sep 27, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 6, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10023

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (18.45s)

bflad added 3 commits September 6, 2019 01:20
@bflad
provider: Implement replacement functions for tls_private_key and tls…
b33af5c 
…_self_signed_certificate test configuration resources

Reference: #10023
@bflad
data-source/aws_acm_certificate: Switch from terraform-provider-tls t…
8e7a3a3 
…o internal functions

Reference: #10023

Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (18.45s)
```
@bflad
provider: Minor fixes to TLS function comments and go fmt
2e4d790
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Sep 6, 2019
@bflad bflad mentioned this pull request Sep 6, 2019
Closed
@ghost ghost added service/acm Issues and PRs that pertain to the acm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 6, 2019
@aeschright aeschright requested a review from a team September 26, 2019 00:12
@aeschright aeschright self-assigned this Sep 26, 2019
aeschright
aeschright approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (19.66s)

@bflad bflad added this to the v2.31.0 milestone Sep 27, 2019
@bflad bflad marked this pull request as ready for review September 27, 2019 01:28
@bflad bflad merged commit c0b241a into master Sep 27, 2019
@bflad bflad deleted the v-terraform-provider-tls branch September 27, 2019 01:28
@ghost
Copy link

ghost commented Oct 3, 2019

This has been released in version 2.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees

@aeschright aeschright

Labels
service/acm Issues and PRs that pertain to the acm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @aeschright