Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove github.com/terraform-providers/terraform-provider-template #10021

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 6, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10020

Release note for CHANGELOG:

NONE

The TestAccAWSDBInstance_diffSuppressInitialState test removal is due to this functionality already being covered by this line in the TestAccAWSDBInstance_basic test: https://github.com/terraform-providers/terraform-provider-aws/blob/1cccd8185fbffa195a039768f65af85a9647c27e/aws/resource_aws_db_instance_test.go#L94

Output from acceptance testing:

--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (383.33s)

--- PASS: TestAccAWSLambdaFunction_localUpdate (41.07s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (56.22s)

--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (17.37s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (40.59s)

Reference: #10020

The `TestAccAWSDBInstance_diffSuppressInitialState` test removal is due to this functionality already being covered by this line in the `TestAccAWSDBInstance_basic` test: https://github.com/terraform-providers/terraform-provider-aws/blob/1cccd8185fbffa195a039768f65af85a9647c27e/aws/resource_aws_db_instance_test.go#L94

Output from acceptance testing:

```
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (383.33s)

--- PASS: TestAccAWSLambdaFunction_localUpdate (41.07s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (56.22s)

--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (17.37s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (40.59s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Sep 6, 2019
@bflad bflad requested a review from a team September 6, 2019 01:41
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. service/emr Issues and PRs that pertain to the emr service. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 6, 2019
@bflad bflad requested a review from a team September 23, 2019 17:19
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad added this to the v2.30.0 milestone Sep 23, 2019
@bflad bflad merged commit 7135acf into master Sep 23, 2019
@bflad bflad deleted the v-terraform-provider-template branch September 23, 2019 17:49
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. service/emr Issues and PRs that pertain to the emr service. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. service/ssm Issues and PRs that pertain to the ssm service. size/XXL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove terraform-provider-template dependency
2 participants