Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging configuration to Prometheus #26444

Closed
barthel opened this issue Aug 23, 2022 · 4 comments · Fixed by #27213
Closed

Add logging configuration to Prometheus #26444

barthel opened this issue Aug 23, 2022 · 4 comments · Fixed by #27213
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/amp Issues and PRs that pertain to the amp service.
Milestone

Comments

@barthel
Copy link

barthel commented Aug 23, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The Amazon Managed Prometheus provides configuration to send log events to CloudWatch.
I would suggest to add two new fields on 'aws_prometheus_workspace' like:

  • log_level
  • cloudwatch_log_group_arn

New or Affected Resource(s)

  • aws_prometheus_workspace

Potential Terraform Configuration

resource "aws_cloudwatch_log_group" "prometheus" {
...
}

resource "aws_prometheus_workspace" "prometheus" {
  alias = "LogMon Prometheus Workspace"

  log_level = "ALL"
  cloudwatch_log_group_arn = aws_cloudwatch_log_group.prometheus.arn
}

References

@barthel barthel added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 23, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/amp Issues and PRs that pertain to the amp service. service/logs Issues and PRs that pertain to the logs service. labels Aug 23, 2022
@ewbankkit ewbankkit removed needs-triage Waiting for first response or review from a maintainer. service/logs Issues and PRs that pertain to the logs service. labels Aug 23, 2022
@kamilturek
Copy link
Collaborator

I might pick it up soon.

nclaeys added a commit to nclaeys/terraform-provider-aws that referenced this issue Oct 12, 2022
add cloudwatch_log_group_arn to aws_prometheus_workspace
@nclaeys
Copy link
Contributor

nclaeys commented Oct 12, 2022

I made a first attempt to add the cloudwatch_log_group_arn to the workspace configuration.

I did not ad the log_level as it actually does not exist in the API and in the UI has values off/All. For me it seemed more clear to just make the cloudwatch_log_group_arn attribute optional.

@github-actions github-actions bot added this to the v4.35.0 milestone Oct 13, 2022
@github-actions
Copy link

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/amp Issues and PRs that pertain to the amp service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants