provider: Add Terraform AWS Provider Version to User-Agent Header

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently the HTTP User-Agent header sent by Terraform AWS Provider requests include the following (plus anything locally added via the TF_APPEND_USER_AGENT environment variable):

User-Agent: aws-sdk-go/1.37.4 (go1.15.7; darwin; amd64) APN/1.0 HashiCorp/1.0 Terraform/0.14.5 (+https://www.terraform.io)

It can be very helpful for troubleshooting to also see the Terraform AWS Provider version as well. This should be filled in with the proper version during releases and use a fallback dev version for local development. The provider implementation will need to match the current TeamCity release injection point LD_FLAGS="-s -w -X $PROVIDER_PACKAGE/version.ProviderVersion=$DEPLOYMENT_TARGET_VERSION -X $PROVIDER_PACKAGE/version.ProtocolVersion=$PROTOCOL_VERSION" (we do not need ProtocolVersion) and will need to be added to the goreleaser handling when it eventually supplants TeamCity.

The proposed User-Agent product and version is:

terraform-provider-aws/3.27.0 (+https://registry.terraform.io/providers/hashicorp/aws/)

Which can be added to aws/config.go:

		UserAgentProducts: []*awsbase.UserAgentProduct{
			{Name: "APN", Version: "1.0"},
			{Name: "HashiCorp", Version: "1.0"},
			{Name: "Terraform", Version: c.terraformVersion, Extra: []string{"+https://www.terraform.io"}},
			{Name: "terraform-provider-aws", Version: /* ... */, Extra: []string{"+https://registry.terraform.io/providers/hashicorp/aws/"}},
		},

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!