Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD_GENERAL1_2XLARGE compute_type support for CodeBuild #10979

Closed
DzmitrySudnik opened this issue Nov 22, 2019 · 5 comments · Fixed by #11015
Closed

Add BUILD_GENERAL1_2XLARGE compute_type support for CodeBuild #10979

DzmitrySudnik opened this issue Nov 22, 2019 · 5 comments · Fixed by #11015
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/codebuild Issues and PRs that pertain to the codebuild service.
Milestone

Comments

@DzmitrySudnik
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add support for a new compute type for CodeBuild, see AWS announcement linked below

New or Affected Resource(s)

  • aws_codebuild_project

References

AWS announcement for a new compute type for CodeBuild:

@DzmitrySudnik DzmitrySudnik added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 22, 2019
@ghost ghost added the service/codebuild Issues and PRs that pertain to the codebuild service. label Nov 22, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 22, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Nov 22, 2019
@bflad bflad added the good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. label Nov 22, 2019
@DzmitrySudnik
Copy link
Contributor Author

My naive attempt (very first experience in go for me) failed miserably on upgrading aws-sdk (since that constant is not in 2.38 which is currently used). Don't have time to learn go package management today, any help is welcome. Also see a parallel attempt just to upgrade that dependency and it looks pretty huge and scary: #10955

@bflad
Copy link
Contributor

bflad commented Nov 26, 2019

@DzmitrySudnik the latest AWS Go SDK has now been merged.

@ghost
Copy link

ghost commented Nov 27, 2019

This has been released in version 2.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
2 participants