-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeouts/schema.go - documentation #51
Comments
Hi @jbinko 👋 Thank you for the feedback. I think that your suggestion of modifying the |
…e timeouts would be applicable (#51)
* Adding description for each of the timeout attributes (#51) * Adding changelog entries (#51) * Amend attribute description to make valid time units clearer (#51) * Amend attribute description for read and delete to indicate when these timeouts would be applicable (#51) * Adding additional options to allow overriding of default descriptions (#51) * Adding changelog entries (#51) * Fixing changelog entry (#51) * Updating README (#51) * Apply suggestions from code review Co-authored-by: Brian Flad <bflad417@gmail.com> * Updating to latest version of terraform-plugin-framework and fixing tests (#51) --------- Co-authored-by: Brian Flad <bflad417@gmail.com>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Terraform CLI and Framework Versions
1.4.5
Use Cases or Problem Statement
Below is output of go run github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs
if you specify in schema timeouts attribute
"timeouts": timeouts.AttributesAll(ctx),
Output:
Nested Schema for timeouts
Optional:
create (String)
delete (String)
read (String)
update (String)
Proposal
It's not nice. I believe if we change timeouts/schema.go and for each create/delete/read/update attribute specify generic Description field like "(Defaults to XX minutes) Used when creating the resource." it will provide better results and will save time to developers.
Additional Information
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: