Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeouts/schema.go - documentation #51

Closed
1 task done
jbinko opened this issue Apr 26, 2023 · 2 comments · Fixed by #52
Closed
1 task done

timeouts/schema.go - documentation #51

jbinko opened this issue Apr 26, 2023 · 2 comments · Fixed by #52
Labels
enhancement New feature or request

Comments

@jbinko
Copy link

jbinko commented Apr 26, 2023

Terraform CLI and Framework Versions

1.4.5

Use Cases or Problem Statement

Below is output of go run github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs
if you specify in schema timeouts attribute
"timeouts": timeouts.AttributesAll(ctx),

Output:

Nested Schema for timeouts
Optional:

create (String)
delete (String)
read (String)
update (String)

Proposal

It's not nice. I believe if we change timeouts/schema.go and for each create/delete/read/update attribute specify generic Description field like "(Defaults to XX minutes) Used when creating the resource." it will provide better results and will save time to developers.

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jbinko jbinko added the enhancement New feature or request label Apr 26, 2023
@bendbennett
Copy link
Contributor

Hi @jbinko 👋

Thank you for the feedback. I think that your suggestion of modifying the Description fields will yield a more informative user experience. A PR along these lines will be forthcoming.

bendbennett added a commit that referenced this issue Apr 28, 2023
bendbennett added a commit that referenced this issue May 5, 2023
bendbennett added a commit that referenced this issue Jun 9, 2023
bendbennett added a commit that referenced this issue Jun 9, 2023
bendbennett added a commit that referenced this issue Jun 9, 2023
bendbennett added a commit that referenced this issue Jun 20, 2023
* Adding description for each of the timeout attributes (#51)

* Adding changelog entries (#51)

* Amend attribute description to make valid time units clearer (#51)

* Amend attribute description for read and delete to indicate when these timeouts would be applicable (#51)

* Adding additional options to allow overriding of default descriptions (#51)

* Adding changelog entries (#51)

* Fixing changelog entry (#51)

* Updating README (#51)

* Apply suggestions from code review

Co-authored-by: Brian Flad <bflad417@gmail.com>

* Updating to latest version of terraform-plugin-framework and fixing tests (#51)

---------

Co-authored-by: Brian Flad <bflad417@gmail.com>
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants