internal/lsp: recognize type declarations as semantic tokens #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
enhancement
radeksimko
force-pushed
the
f-type-decl-highlighting
branch
from
d1beaec to
c1dd2e4
Compare
radeksimko
force-pushed
the
f-type-decl-highlighting
branch
from
c1dd2e4 to
e2385c7
Compare
|
This functionality has been released in v0.26.0 of the language server. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #816
Before
After
Related Thoughts
It is possible that we may want to replace the two tokens with something even more accurate, like
TokenTypeString,TokenTypeNumber,TokenTypeSet,TokenTypeListetc. but it is currently unclear whether anyone would actually benefit from that. We can always revisit supported tokens later.We can also see that the VSCode grammar highlights types as variables. I would say that keyword scope is more appropriate, as that leaves variable scope for HCL traversals and allows us to visually distinguish the two. i.e. We can adjust the highlighting of primitive types like
string,number,nullorboolin the grammar as well.