Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: repurpose indexer-related options #1003

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

radeksimko
Copy link
Member

Closes #704

@radeksimko radeksimko marked this pull request as ready for review July 18, 2022 11:00
@radeksimko radeksimko requested a review from a team as a code owner July 18, 2022 11:00
@radeksimko radeksimko added this to the v0.29.0 milestone Jul 18, 2022
@radeksimko radeksimko requested a review from jpogran July 18, 2022 12:35
@radeksimko
Copy link
Member Author

Tagging @jpogran as you dealt with settings in the VS Code extension recently:

We could potentially move both ignoreDirectoryNames and ignorePaths under indexing or similar, to indicate these options are related to indexing. This can of course be also done just on the client side, but I thought I'd flag it up here as we're touching the settings.

Also I can prepare a PR for the extension which reflects these changes and decisions.

@radeksimko radeksimko self-assigned this Jul 18, 2022
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Does this qualify as a breaking change and requires extra communication?

@radeksimko
Copy link
Member Author

Does this qualify as a breaking change and requires extra communication?

Yes, I expect we'd call it out as such in the Changelog.

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@jpogran
Copy link
Contributor

jpogran commented Jul 19, 2022

Tagging @jpogran as you dealt with settings in the VS Code extension recently:

We could potentially move both ignoreDirectoryNames and ignorePaths under indexing or similar, to indicate these options are related to indexing. This can of course be also done just on the client side, but I thought I'd flag it up here as we're touching the settings.

Also I can prepare a PR for the extension which reflects these changes and decisions.

👍🏼 on moving to indexing.

I think we've already marked these as deprecated, so we're halfway there

@radeksimko radeksimko force-pushed the f-rework-indexer-settings branch 4 times, most recently from 4dbdb81 to b343e0d Compare July 21, 2022 07:09
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repurpose rootModulePaths and excludeRootModulePaths
3 participants