-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: repurpose indexer-related options #1003
Conversation
Tagging @jpogran as you dealt with settings in the VS Code extension recently: We could potentially move both Also I can prepare a PR for the extension which reflects these changes and decisions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Does this qualify as a breaking change and requires extra communication?
Yes, I expect we'd call it out as such in the Changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
👍🏼 on moving to indexing. I think we've already marked these as deprecated, so we're halfway there |
4dbdb81
to
b343e0d
Compare
b343e0d
to
f8786df
Compare
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Closes #704