Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "top: -9999px" to hide elements instead of "left: -9999px" please! #1413

Closed
neopersia opened this issue Jul 26, 2013 · 2 comments · Fixed by #2727
Closed

Use "top: -9999px" to hide elements instead of "left: -9999px" please! #1413

neopersia opened this issue Jul 26, 2013 · 2 comments · Fixed by #2727

Comments

@neopersia
Copy link

Hi,

I love the chosen plugin but adding the "chzn-rtl" class to every select element in a right to left page is really ridiculous! It's even more annoying when it comes to multilingual pages, in which case you have to add the class pragmatically for every select element!

Why not using the "top" property instead? it's a lot simpler and it won't matter if the page is rtl or ltr.
For the rest of the related css rules, adding a "rtl" class or even a standard dir="rtl" attribute to the body or html tag can render the need for "chzn-rtl" obsolete. That's the way it's handled in the dojotoolkit and I had no problems with that approach ever!

I could start writing codes right away but I've seen this argument in comments for some bugs here and I thought there might be a reason it's been ignored so far.

@kenearley
Copy link

@neopersia At one point I had tried to do what you've suggested. I can't remember what issues I ran into, at the moment. You are more than welcome to make a Pull Request. It would be great to not have to use class for this.

@gptforjoomla
Copy link

I tested, This work for me. good to merge. thank you

@pfiller pfiller removed the Refactor label Jun 3, 2016
koenpunt added a commit that referenced this issue Oct 15, 2016
koenpunt added a commit that referenced this issue Oct 20, 2016
koenpunt added a commit that referenced this issue Oct 21, 2016
* clip results instead of moving them

fixes #1413
fixes #1410
fixes #1686
fixes #2402
fixes #2445
fixes #2185

* no more need for rtl fix in demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants