Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out the thumbnail situation #2315

Closed
rebeccacremona opened this issue Apr 4, 2018 · 1 comment
Closed

Sort out the thumbnail situation #2315

rebeccacremona opened this issue Apr 4, 2018 · 1 comment
Labels
feature Issue type maybe-close Triage hint

Comments

@rebeccacremona
Copy link
Contributor

rebeccacremona commented Apr 4, 2018

  1. Are we being affected by Serious performance issues in 12.2 (AWS S3) jazzband/sorl-thumbnail#351? (Surely yes, but lets investigate the extent.)
    2) What's up with thumbnails and redis on heroku?
  2. What is the point of using thumbnails in the logo carousel in the first place (rather than sizing the images appropriately when we create them)?
  3. If we were to remove the logo carousel, or make them regular images instead of thumbnails, would it be worth keeping/fixing the sorl + redis code, given issues Thumbnails for each link on the my links page #821, If we add back in Thumbnails, display on delete confirm screen  #1146, and Add thumbnails on archive capture #1910 express a pretty strong desire for thumbnail images of captures (once a feature of Perma, not presently a feature)
@rebeccacremona
Copy link
Contributor Author

The plan, per in-person discussion:

We are going to replace the carousel with a different, less complex design element. @anastasia is going to take a swing at coming up with something (a list of a few prominent registrars? an image? something else?)

With that in place, we are going to rip out the existing code/settings/etc. related to thumbnails, and as much image-processing software as we can.

And then, if we end up adding thumbnails of captures later, per the issues referenced above, we'll research which libraries/combination of libraries we need at that point. It might look just like what we ripped out, but it might not: we can reference the commit that removes the code in the thumbnail issues, to help make sure valuable knowledge isn't lost.

@matteocargnelutti matteocargnelutti added maybe-close Triage hint feature Issue type labels Aug 9, 2022
@matteocargnelutti matteocargnelutti closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issue type maybe-close Triage hint
Projects
None yet
Development

No branches or pull requests

2 participants