Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel (landing and about page) #2240

Closed
rebeccacremona opened this issue Feb 8, 2018 · 1 comment
Closed

Carousel (landing and about page) #2240

rebeccacremona opened this issue Feb 8, 2018 · 1 comment
Labels
accessibility Subcategory

Comments

@rebeccacremona
Copy link
Contributor

rebeccacremona commented Feb 8, 2018

From Bootstrap:

Accessibility issue

The carousel component is generally not compliant with accessibility standards. If you need to be compliant, please consider other options for presenting your content.

This library is usually pretty good, and has a patch for at least partially accessibility: https://github.com/paypal/bootstrap-accessibility-plugin. Look into that, and see how it goes. Maybe we can get it good enough?

The controls for the carousel should be buttons, not links, and they need to be labeled.
https://github.com/harvard-lil/perma/blob/develop/perma_web/perma/templates/includes/participating_institutions.html#L19

Also the "carousel indicators" are just <li> right now; they should be buttons

(maybe we can rip out this whole thing......)

@rebeccacremona rebeccacremona added the accessibility Subcategory label Feb 8, 2018
@rebeccacremona rebeccacremona changed the title Carousel buttons Carousel Feb 8, 2018
@rebeccacremona rebeccacremona changed the title Carousel Landing page carousel Feb 8, 2018
@rebeccacremona rebeccacremona changed the title Landing page carousel Carousel (landing and about page) Feb 8, 2018
@rebeccacremona
Copy link
Contributor Author

We're going to remove the carousel. See #2315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Subcategory
Projects
None yet
Development

No branches or pull requests

1 participant