fix: Fixing return type for response headers #36

vardanbansal-harness · 2024-10-23T23:35:07Z

Fetcher return type now updated to

export interface {{typeName}}ResponseContainer {
  body: {{okResponseName}}
  headers: Headers
}

NA

Contributor license agreement

abhinavrastogi-harness

technically this is again a breaking change.. but since we just published the other version, maybe lets make this 4.1.0 instead

vardanbansal-harness · 2024-10-24T22:03:16Z

technically this is again a breaking change.. but since we just published the other version, maybe lets make this 4.1.0 instead

Makes sense, done ✅.

fix return type

315746c

abhinavrastogi-harness previously approved these changes Oct 24, 2024

View reviewed changes

vardanbansal-harness added 2 commits October 24, 2024 14:58

update minor version

1067fab

regen types as per new return type

362c198

vardanbansal-harness dismissed abhinavrastogi-harness’s stale review via 362c198 October 24, 2024 22:00

cjlee01 previously approved these changes Oct 24, 2024

View reviewed changes

vardanbansal-harness added 2 commits October 28, 2024 13:26

fixing type for headers

dab5a7c

rename content to body

bcf56ca

vardanbansal-harness dismissed cjlee01’s stale review via bcf56ca October 28, 2024 20:34

vardanbansal-harness changed the title ~~fix: Add correct type for Response headers~~ fix: Fixing return type for response headers Oct 28, 2024

major version upgrade

d92d009

abhinavrastogi-harness approved these changes Oct 29, 2024

View reviewed changes

cjlee01 approved these changes Oct 29, 2024

View reviewed changes

vardanbansal-harness merged commit 6747255 into main Oct 29, 2024
4 checks passed

vardanbansal-harness deleted the add-types-to-response-headers branch October 29, 2024 23:46