Remove some upstream ignores (#2879)

* Remove some upstream ignores These are already being ignored * Fix some describes * restore ignore
hardkoded · Feb 12, 2025 · 0959052 · 0959052
1 parent 47a7dcd
commit 0959052
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 59 deletions.
diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
@@ -330,21 +330,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[coverage.spec] *",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[crash] *",
@@ -360,21 +345,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[debugInfo.spec] *",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[defaultbrowsercontext.spec] *",

diff --git a/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/ParseAriaSelectorTests.cs b/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/ParseAriaSelectorTests.cs
@@ -6,7 +6,7 @@ namespace PuppeteerSharp.Tests.AriaQueryHandlerTests
 {
     public class ParseAriaSelectorTests : PuppeteerPageBaseTest
     {
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "parseAriaSelector", "should handle non-breaking spaces")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler parseAriaSelector", "should handle non-breaking spaces")]
         public async Task ShouldHandleNonBreakingSpaces()
         {
             await Page.SetContentAsync(
@@ -19,7 +19,7 @@ await Page.SetContentAsync(
             Assert.That(button, Is.Null);
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "parseAriaSelector", "should handle non-breaking spaces")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler parseAriaSelector", "should handle non-breaking spaces")]
         public async Task ShouldHandleNonBreakingSpaces2()
         {
             await Page.SetContentAsync(
@@ -32,7 +32,7 @@ await Page.SetContentAsync(
             await ExpectFound(button);
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "parseAriaSelector", "should handle zero width spaces")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler parseAriaSelector", "should handle zero width spaces")]
         public async Task ShouldHandleZeroWidthSpaces()
         {
             await Page.SetContentAsync(
@@ -45,7 +45,7 @@ await Page.SetContentAsync(
             Assert.That(button, Is.Null);
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "parseAriaSelector", "should find button")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler parseAriaSelector", "should find button")]
         public async Task ShouldFindButton()
         {
             await Page.SetContentAsync(@"

diff --git a/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/QueryAllArrayTests.cs b/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/QueryAllArrayTests.cs
@@ -6,11 +6,7 @@ namespace PuppeteerSharp.Tests.AriaQueryHandlerTests
 {
     public class QueryAllArrayTests : PuppeteerPageBaseTest
     {
-        public QueryAllArrayTests() : base()
-        {
-        }
-
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "queryAllArray", "$$eval should handle many elements")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler queryAllArray", "$$eval should handle many elements")]
         public async Task EvalShouldHandleManyElements()
         {
             await Page.SetContentAsync("");

diff --git a/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/QueryAllTests.cs b/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/QueryAllTests.cs
@@ -8,7 +8,7 @@ namespace PuppeteerSharp.Tests.AriaQueryHandlerTests
 {
     public class QueryAllTests : PuppeteerPageBaseTest
     {
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "queryAll", "should find menu by name")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler queryAll", "should find menu by name")]
         public async Task ShouldFindMenuByName()
         {
             await Page.SetContentAsync(@"

diff --git a/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/QueryOneTests.cs b/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/QueryOneTests.cs
@@ -6,11 +6,7 @@ namespace PuppeteerSharp.Tests.AriaQueryHandlerTests
 {
     public class QueryOneTests : PuppeteerPageBaseTest
     {
-        public QueryOneTests() : base()
-        {
-        }
-
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "queryOne", "should find button by role")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler queryOne", "should find button by role")]
         public async Task ShouldFindButtonByRole()
         {
             await Page.SetContentAsync("<div id='div'><button id='btn' role='button'>Submit</button></div>");
@@ -19,7 +15,7 @@ public async Task ShouldFindButtonByRole()
             Assert.That(id, Is.EqualTo("btn"));
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "queryOne", "should find button by name and role")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler queryOne", "should find button by name and role")]
         public async Task ShouldFindButtonNameAndByRole()
         {
             await Page.SetContentAsync("<div id='div'><button id='btn' role='button'>Submit</button></div>");
@@ -28,7 +24,7 @@ public async Task ShouldFindButtonNameAndByRole()
             Assert.That(id, Is.EqualTo("btn"));
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "queryOne", "should find first matching element")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler queryOne", "should find first matching element")]
         public async Task ShouldFindFirstMatchingElement()
         {
             await Page.SetContentAsync(@"
@@ -40,7 +36,7 @@ await Page.SetContentAsync(@"
             Assert.That(id, Is.EqualTo("mnu1"));
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "queryOne", "should find by name")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler queryOne", "should find by name")]
         public async Task ShouldFindByName()
         {
             await Page.SetContentAsync(@"
@@ -52,7 +48,7 @@ await Page.SetContentAsync(@"
             Assert.That(id, Is.EqualTo("mnu1"));
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "queryOne", "should find by name")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler queryOne", "should find by name")]
         public async Task ShouldFindByName2()
         {
             await Page.SetContentAsync(@"

diff --git a/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/WaitForSelectorAriaTests.cs b/lib/PuppeteerSharp.Tests/AriaQueryHandlerTests/WaitForSelectorAriaTests.cs
@@ -10,15 +10,15 @@ public class WaitForSelectorAriaTests : PuppeteerPageBaseTest
     {
         private const string AddElement = @"(tag) => document.body.appendChild(document.createElement(tag))";
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should immediately resolve promise if node exists")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should immediately resolve promise if node exists")]
         public async Task ShouldImmediatelyResolvePromiseIfNodeExists()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
             await Page.EvaluateFunctionAsync(AddElement, "button");
             await Page.WaitForSelectorAsync("aria/[role=\"button\"]");
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should work for ElementHandle.waitForSelector")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should work for ElementHandle.waitForSelector")]
         public async Task ShouldWorkForElementHandleWaitForSelector()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
@@ -30,7 +30,7 @@ await Page.EvaluateFunctionAsync(
             await element.WaitForSelectorAsync("aria/test");
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should persist query handler bindings across reloads")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should persist query handler bindings across reloads")]
         public async Task ShouldPersistQueryHandlerBindingsAcrossReloads()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
@@ -41,7 +41,7 @@ public async Task ShouldPersistQueryHandlerBindingsAcrossReloads()
             await Page.WaitForSelectorAsync("aria/[role=\"button\"]");
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should persist query handler bindings across navigations")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should persist query handler bindings across navigations")]
         public async Task ShouldPersistQueryHandlerBindingsAcrossNavigations()
         {
             await Page.GoToAsync("data:text/html,");
@@ -52,7 +52,7 @@ public async Task ShouldPersistQueryHandlerBindingsAcrossNavigations()
             await Page.WaitForSelectorAsync("aria/[role=\"button\"]");
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should work independently of `exposeFunction")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should work independently of `exposeFunction")]
         public async Task ShouldWorkIndependentlyOfExposeFunction()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
@@ -63,7 +63,7 @@ public async Task ShouldWorkIndependentlyOfExposeFunction()
             Assert.That(result, Is.EqualTo(10));
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should work with removed MutationObserver")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should work with removed MutationObserver")]
         public async Task ShouldWorkWithRemovedMutationObserver()
         {
             await Page.EvaluateFunctionAsync(@"() => delete window.MutationObserver");
@@ -75,7 +75,7 @@ await Task.WhenAll(
             Assert.That(await Page.EvaluateFunctionAsync<string>("x => x.textContent", handleTask.Result), Is.EqualTo("anything"));
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should resolve promise when node is added")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should resolve promise when node is added")]
         public async Task ShouldResolvePromiseWhenNodeIsAdded()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
@@ -90,7 +90,7 @@ await elementHandle.GetPropertyAsync("tagName")
             Assert.That(tagName, Is.EqualTo("H1"));
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should work when node is added through innerHTML")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should work when node is added through innerHTML")]
         public async Task ShouldWorkWhenNodeIsAddedThroughInnerHtml()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
@@ -103,7 +103,7 @@ await Page.EvaluateFunctionAsync(@"() => {
             await watchdog;
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "Page.waitForSelector is shortcut for main frame")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "Page.waitForSelector is shortcut for main frame")]
         public async Task PageWaitForSelectorIsShortcutForMainFrame()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
@@ -116,7 +116,7 @@ public async Task PageWaitForSelectorIsShortcutForMainFrame()
             Assert.That(Page.MainFrame, Is.SameAs(elementHandle.Frame));
         }
 
-        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "waitForSelector (aria)", "should run in specified frame")]
+        [Test, Retry(2), PuppeteerTest("ariaqueryhandler.spec", "AriaQueryHandler waitForSelector (aria)", "should run in specified frame")]
         public async Task ShouldRunInSpecifiedFrame()
         {
             await FrameUtils.AttachFrameAsync(Page, "frame1", TestConstants.EmptyPage);