Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Updated TD-MPC2 evaluation and fixed some bugs #538

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[Feature] Updated TD-MPC2 evaluation and fixed some bugs #538

merged 1 commit into from
Sep 3, 2024

Conversation

t-sekai
Copy link
Contributor

@t-sekai t-sekai commented Aug 30, 2024

#439

  • Separated eval_env from train env (Align evaluation setups for different online RL algorithms #486)
    • eval_env is now used for evaluation. The only difference between env and eval_env is num_envs.
    • num_eval_envs in configs now defines the num_envs of eval_env.
  • Fixed max_episode_steps (tdmpc2 baseline AttributeError: 'ManiSkillVectorEnv' object has no attribute 'max_episode_steps' #528)
    • Newer gymnasium and ManiskillVectorEnv doesn't contrain default max_episode_steps as an attribute. Therefore, default max_episode_steps is now determined by gym_utils.find_max_episode_steps_value(env).
  • Fixed wandb logging to log exactly eval_episodes
    • Realized that wandb logging in evaluation wasn't logging exactly eval_episodes (it was a multiple of num_eval_envs). Futhermore, only num_eval_envs videos were logged at each evaluation.
    • It is now fixed to log exactly eval_episodes at each evaluation.

…ps (Issue #528), fixed wandb logging (now logging exactly eval_episodes)
@t-sekai t-sekai changed the title Updated TD-MPC2 evaluation and fixed some bugs [Feature] Updated TD-MPC2 evaluation and fixed some bugs Aug 30, 2024
@StoneT2000 StoneT2000 merged commit abb2281 into haosulab:main Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants