Feature: Add SkyHanni User Luck to stats breakdown #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
hannibal002
added
the
Soon
hannibal002
requested changes
Jun 16, 2024
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
lunaynx
suggested changes
Jun 16, 2024
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/UserLuckBreakdown.kt
Outdated
Show resolved
Hide resolved
hannibal002
approved these changes
Jun 16, 2024
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the SkyHanni User Luck stat to the stats breakdown in
/sbmenu,/equipmentand "Misc Stats" in it's submenu.Follows the same visibility rules as other Hypixel stats. Example: Only visible when on a non default value, respects "Toggle show all stats".
Adds a custom stats breakdown menu for SkyHanni User Luck, has support for future new sources, but would probably need a bit of extra work for a new sub-sub menu for a future skills breakdown.
very much needs a new stat description, maybe a new item to represent the general stat.
video showcase
screenshots are a bit outdated and don't include the new menu
Changelog New Features