Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added Highlighting for tab widgets. #1175

Merged
merged 12 commits into from
Mar 24, 2024
Merged

Feature: Added Highlighting for tab widgets. #1175

merged 12 commits into from
Mar 24, 2024

Conversation

Conutik
Copy link
Contributor

@Conutik Conutik commented Mar 14, 2024

What

Highlight tab widgets depending on their status.

Images

https://conutik.catto.pics/68d759a4

Changelog New Features

  • Highlight options in /tab. - Conutik
    • Green for enabled
    • Red for disabled

@Conutik Conutik requested a review from Thunderblade73 March 14, 2024 17:48
Thunderblade73
Thunderblade73 suggested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback on how we do stuff / what the contributor Guidelines request + a major performance improvement

@hannibal002 hannibal002 changed the title Added Highlighting for tab widgets. Feature: Added Highlighting for tab widgets. Mar 14, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Mar 14, 2024
@hannibal002 hannibal002 added this to the Version 0.24 milestone Mar 14, 2024
@Conutik Conutik requested a review from Thunderblade73 March 14, 2024 21:07
CalMWolfs
CalMWolfs requested changes Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to these three things please run the intellij formatter and remove unneeded comments

Thunderblade73
Thunderblade73 suggested changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small changes

CalMWolfs
CalMWolfs requested changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other changes look good just these last bits of formatting

@Conutik Conutik requested a review from CalMWolfs March 17, 2024 11:35
hannibal002
hannibal002 requested changes Mar 17, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly fine for me. Just several code cleanup suggestions.

Conutik and others added 3 commits March 19, 2024 15:45
@Conutik @hannibal002
Update src/main/java/at/hannibal2/skyhanni/features/misc/TabWidgetSet…
4d3129f 
…tings.kt

Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
@Conutik @hannibal002
Update src/main/java/at/hannibal2/skyhanni/features/misc/TabWidgetSet…
2ac7739 
…tings.kt

Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
@Conutik
Added changes
b383ff2
@Conutik Conutik requested a review from hannibal002 March 19, 2024 12:59
hannibal002
hannibal002 requested changes Mar 21, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the part where you set inInventory to true, the current state of this pr does no longer work at all.

@Conutik Conutik requested review from hannibal002 and ItsEmpa March 22, 2024 13:27
hannibal002
hannibal002 requested changes Mar 22, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now, it only works in the sub settings, not in the main inventory though.
the mainPageSettingPattern regex is Widgets on.*, but the inventory name is "widgets in xy". are the pattern names confusing or is something else missing here?

@Conutik Conutik requested a review from hannibal002 March 24, 2024 09:37
@hannibal002 hannibal002 merged commit d03dce8 into hannibal002:beta Mar 24, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Mar 24, 2024
superhize pushed a commit to superhize/SkyHanni that referenced this pull request Apr 8, 2024
@Conutik @hannibal002 @superhize
Feature: Added Highlighting for tab widgets. (hannibal002#1175)
00446e5 
Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

@Thunderblade73 Thunderblade73 Awaiting requested review from Thunderblade73

@CalMWolfs CalMWolfs Awaiting requested review from CalMWolfs

@ItsEmpa ItsEmpa Awaiting requested review from ItsEmpa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.24
Development

Successfully merging this pull request may close these issues.
5 participants
@Conutik @hannibal002 @ItsEmpa @Thunderblade73 @CalMWolfs