Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to R2DBC MySQL 1.4.0 #7237

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR upgrades to R2dbc MySQL 1.4.0 and tries to fix #6854.

Which issue(s) this PR fixes:

Fixes #6854

Does this PR introduce a user-facing change?

升级依赖 R2DBC MySQL 至 1.4.0

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 21, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Feb 21, 2025
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Feb 21, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen February 21, 2025 04:11
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.24%. Comparing base (eff73dc) to head (682db52).
Report is 97 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7237      +/-   ##
============================================
+ Coverage     56.99%   57.24%   +0.24%     
- Complexity     3999     4050      +51     
============================================
  Files           714      719       +5     
  Lines         24110    24395     +285     
  Branches       1585     1600      +15     
============================================
+ Hits          13742    13965     +223     
- Misses         9756     9811      +55     
- Partials        612      619       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
Copy link

f2c-ci-robot bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 0cdd8d1 into halo-dev:main Feb 21, 2025
9 checks passed
@JohnNiang JohnNiang deleted the chore/upgrade-to-r2dbc-mysql-1.4.0 branch February 22, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suddenly encountered a "Connection validation failed" error
2 participants