Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS detection order is incorrect #44

Closed
heaths opened this issue Sep 28, 2024 · 0 comments · Fixed by #45 or #47
Closed

CODEOWNERS detection order is incorrect #44

heaths opened this issue Sep 28, 2024 · 0 comments · Fixed by #45 or #47
Labels
bug Something isn't working

Comments

@heaths
Copy link
Contributor

heaths commented Sep 28, 2024

for _, p := range []string{".", "docs", ".github", ".gitlab"} {

I happened to notice this while looking into fixing #43: according to https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location the order is wrong. It should check for a CODEOWNERS file in .github/ (and presumably .gitlab/) first, then the root, then under docs/.

For most repos this likely won't matter since they probably only have a single CODEOWNERS file anyway, but matching the documented order could matter for some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants