Housekeeping #6
Merged
Housekeeping #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default this is disabled, so function signatures only show argument names and defaults, not types. (Types are shown in the parameters table either way.)
The version of mypy we just upgraded to includes generic annotations for memoryview, which result in our jsbuffers annotations producing type errors. This works around the errors by returning `memoryview[Any]`, rather than just `memoryview`, as this means `memoryview[int]`. I've partially implemented type-safe memoryview casting from our format metadata types, but not entirely as it will require more refactoring than I want to do to fix this immediate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dev deps, configure linting better, fix some lint errors.
Also configure quartodoc to include annotations in function signatures.