Skip to content

Commit

Permalink
build(ci): ensure echoserver healthy before testing
Browse files Browse the repository at this point in the history
The integration tests now wait for the echoserver containers to be
healthy before running. This should avoid tests failing due to failing
to connect to the echoserver(s) while they're starting.

For example: https://github.com/h4l/v8serialize/actions/runs/12533338515/job/34952929385
  • Loading branch information
h4l committed Dec 29, 2024
1 parent 03e5076 commit 215879a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
pull_request:

env:
ECHOSERVER_VERSION: 0.2.0
ECHOSERVER_VERSION: 0.3.0

jobs:
prepare_checks:
Expand Down
9 changes: 6 additions & 3 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@ services:
environment:
V8SERIALIZE_ECHOSERVERS: "${V8SERIALIZE_ECHOSERVERS:-__required_but_not_set__}"
depends_on:
- echoserver-node-22
- echoserver-node-18
- echoserver-deno
echoserver-node-22:
condition: service_healthy
echoserver-node-18:
condition: service_healthy
echoserver-deno:
condition: service_healthy
command: pytest -m integration -vv
volumes:
- .:${WORKSPACE_MOUNT_PATH:-/workspace}
Expand Down

0 comments on commit 215879a

Please sign in to comment.