Use URL-based path resolution in HTTPStore
#99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #42 we migrated from
URL
-based path resolution to a more simple string concatenation. This PR fixes the same issue as #42 but reverts back to usingURL
.It also adds a feature requested for forwarding search query params when resolving the new URL, so that an
HTTPStore
can be instantiated as follows:Generally I'd be in favor of migrating the type of
HTTPStore.url
toURL
, but since it is a public field I have set it to a generic (with default tostring
).cc: @ilan-gold