Remove ts-interface checking, add stats HTML, modern target #70
Conversation
gzuidhof
changed the title
There was a problem hiding this comment.
Nice, thanks for taking the first steps in this direction. Love the updated ES target; I think it's perfect for something like this package.
Odds are if you're using Zarr.js, it will be in a modern browser, and if not, you can transpile with your own build tools.
| watch: { | ||
| include: 'src/**', | ||
| }, | ||
| plugins: [typescript({ useTsconfigDeclarationDir: true }), commonjs(), resolve()], | ||
| plugins: [...commonPlugins(), visualizer({filename: "stats.html"}), visualizer({filename: "stats.min.html", sourcemap: true})], |
There was a problem hiding this comment.
Can plugins === commonPlugins() here and output[0].plugins === [ visualizer({filename: "stats.html"}) ] and output[1].plugins === [ terser(), visualizer({filename: "stats.min.html", sourcemap: true }) ]
There was a problem hiding this comment.
The visualizer plugin didn't want to be an output plugin so I had to use this workaround
| }), | ||
| commonjs(), | ||
| resolve(), | ||
| ...commonPlugins() |
There was a problem hiding this comment.
nit: no need to spread, just plugins === commonPlugins(), unless you think leaving room for future node-specific plugins is useful.
|
Just wanted to follow up on this. Any thing I can do to land this PR and create a new release? This is a great first step, thank you! |
|
Sorry for the late reply - I'm happy to merge it as is and then we can mint a new release :). |
A first step towards slimming down Zarr