Recursively reason over flow control relationships #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
commented
Mar 20, 2024
| # if a state is present in a rate law, and the state isn't an input to the rate | ||
| # law, then that state is a controller of the rate law | ||
| if ( |
There was a problem hiding this comment.
@nanglo123 please resurrect this, and maybe we can add some unit tests that correspond to when this gets used
nanglo123
force-pushed
the
recursive-flow-control
branch
from
b96a680 to
923a344
Compare
cthoyt
commented
Mar 28, 2024
mira/sources/system_dynamics/pysd.py
Outdated
| @@ -564,3 +582,69 @@ def with_lookup_to_piecewise(expr_text: str) -> str: | |||
| conditions = ",".join(f"({y}, {variable} >= {x})" for x, y in pairs) | |||
| sympy_str = f"Piecewise({conditions})" | |||
| return sympy_str | |||
|
|
|||
|
|
|||
| def get_identifier_to_expr(pysd_model, name_to_expr_str): | |||
There was a problem hiding this comment.
@nanglo123 here's the function that resolves the recursive rate laws
There's still an issue where we're not picking up anything interesting in terms of controllers for the rate laws
… and stocks in rate laws, fix way to identify links from stock flow amr
nanglo123
force-pushed
the
recursive-flow-control
branch
from
ccd67c7 to
9343e28
Compare
bgyori
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal in this PR is when importing vensim models, to recursively walk through all of the flow relationships to identify for each, what are the stocks involved. This will allow for making more appropriate control structure that for each relationship can properly incorporate controllers based on the stocks referenced in the rate law.
What's solved:
What's not solved: