Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get physical constants from Wikidata #256

Merged
merged 7 commits into from
Nov 3, 2023
Merged

Get physical constants from Wikidata #256

merged 7 commits into from
Nov 3, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 3, 2023 •
edited
Loading

This PR does the following:

  1. Gets physical constants, their values, their defining formula, and more from Wikidata via a SPARQL query
  2. Incorporates them into the DKG

@cthoyt cthoyt marked this pull request as ready for review November 3, 2023 16:35
@bgyori bgyori force-pushed the physical-constants branch from 9ad10af to 44b9d6c Compare November 3, 2023 16:57
bgyori
bgyori approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@bgyori bgyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@bgyori bgyori merged commit 08f30f5 into main Nov 3, 2023
@cthoyt cthoyt deleted the physical-constants branch November 3, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgyori bgyori bgyori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthoyt @bgyori