-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use grounded names when renaming in stratification #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Oct 31, 2023
cthoyt
reviewed
Oct 31, 2023
cthoyt
reviewed
Oct 31, 2023
cthoyt
reviewed
Oct 31, 2023
cthoyt
reviewed
Oct 31, 2023
cthoyt
reviewed
Oct 31, 2023
mira/metamodel/templates.py
Outdated
[str(v.replace(':', '_')) for _, v in sorted(context.items())]) | ||
name_list = [self._base_name] | ||
for k, v in sorted(context.items()): | ||
nv = name_map.get(v, v) if name_map else v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should add a is_curie
function somewhere that can be used in here to make this code more obvious what it's doing
cthoyt
reviewed
Oct 31, 2023
c71fc4a
to
8635d3a
Compare
bgyori
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the automatically generated stratification names to be more human friendly by passing through a mapping from calling the stratify function down to where the renaming happens: in the the
concept.with_context
method.Tests are added for both the stratify module and for the model api.
When calling the stratify endpoint, a user can provide the name mapping or if no mapping is provided a lazy attempt to map from curies to entity names is done. If the curie mapping also fails, the behavior prior to this PR is expected.
Example