Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3652. Setting Menus causes unexpected Exception. #3653

Merged
merged 17 commits into from
Aug 13, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 8, 2024

Fixes

Proposed Changes/Todos

  • Rename Shortcut to ShortcutKey and change type to Key
  • Change HotKey type to Key
  • Improving add and remove menu items dynamically
  • Allow run an action in IsTopLevel menu bar item through HotKey

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner August 8, 2024 20:42
@BDisp BDisp marked this pull request as draft August 8, 2024 20:43
@BDisp BDisp marked this pull request as ready for review August 10, 2024 23:28
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work!

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks please.

@tig tig merged commit a661fce into gui-cs:v2_develop Aug 13, 2024
3 checks passed
@BDisp BDisp deleted the v2_3652_menubar-improvements branch August 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting Menus causes unexpected Exception Some uses of the CheckStyle enum are buggy
2 participants