Prefer nullish coalescing and optional chaining #6715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
force-pushed
the
mxdvl/nullish-coalesing
branch
from
f9c1f27 to
39153a8
Compare
|
Size Change: -4.1 kB (0%) Total Size: 2.31 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
mxdvl
force-pushed
the
mxdvl/nullish-coalesing
branch
2 times, most recently
from
dfdbd9d to
f6a9c35
Compare
mxdvl
commented
Dec 7, 2022
| @@ -11,7 +11,7 @@ const captionStyle = css` | |||
| padding-top: 10px; | |||
| ${textSans.xxsmall()}; | |||
| word-wrap: break-word; | |||
| color: ${text.supporting}; | |||
| color: ${neutral[46]}; | |||
Comment on lines
28
to
32
| {formField.options.map((option, index) => ( | ||
| <option key={index} value={option.value}> | ||
| {option.value} | ||
| </option> | ||
| ))} |
There was a problem hiding this comment.
The compiler thinks this is always defined
Comment on lines
+31
to
+32
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- window.guardian may be missing? | ||
| if (window?.guardian) { |
There was a problem hiding this comment.
Not sure about that one, but I assumed it was added for a reason
Comment on lines
+231
to
+233
| const isPaidContent = !!tags.find( | ||
| ({ id }) => id === 'tone/advertisement-features', | ||
| ); |
There was a problem hiding this comment.
Seems like we use this in several places…
| @@ -78,7 +78,7 @@ type Props = { | |||
| * @see https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/web/browser/debug/README.md | |||
| */ | |||
| containerName?: string; | |||
| /** Fronts containers can have their styling overidden using a `containerPalette` */ | |||
| /** Fronts containers can have their styling overridden using a `containerPalette` */ | |||
Comment on lines
+470
to
+463
| typeof CAPIArticle.starRating === | ||
| 'number' |
There was a problem hiding this comment.
This is actually what we want, as star rating could be 0
Comment on lines
+7
to
+9
| const fileAsBase64 = reader.result | ||
| ?.toString() | ||
| .split(';base64,')[1]; |
There was a problem hiding this comment.
The compiler thinks reader is always defined
mxdvl
force-pushed
the
mxdvl/nullish-coalesing
branch
from
f6a9c35 to
6cae568
Compare
sndrs
reviewed
Dec 8, 2022
| @@ -6,10 +6,12 @@ export const findPillar: ( | |||
| tags?: TagType[], | |||
| ) => ArticleTheme | undefined = (name, tags?) => { | |||
| // Flag paid content for Labs pillar (for styling purposes) | |||
| const isPaidContent = (tag: TagType) => | |||
| tag.type === 'Tone' && tag.id === 'tone/advertisement-features'; | |||
| const hasPaidContent = !!tags?.some( | |||
There was a problem hiding this comment.
doesn't this coerce tags into a boolean? can you call some on that?
There was a problem hiding this comment.
TypeScript thinks it’s fine, as per the precedence table
mxdvl
force-pushed
the
mxdvl/nullish-coalesing
branch
from
6cae568 to
3b2cf5a
Compare
mxdvl
force-pushed
the
mxdvl/nullish-coalesing
branch
2 times, most recently
from
587a609 to
9d72165
Compare
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
OllysCoding
reviewed
Jan 19, 2023
Comment on lines
+26
to
27
| // This is not safe to remove whilst we have noUncheckedIndexedAccess | ||
| '@typescript-eslint/no-unnecessary-condition': 'warn', |
There was a problem hiding this comment.
Can this change now then?
mxdvl
force-pushed
the
mxdvl/nullish-coalesing
branch
from
9d72165 to
2d22f28
Compare
The following rules are now reported as errors: - nullish coalescing - optional chaining This aligns us closer to the Guardian’s house rules
mxdvl
force-pushed
the
mxdvl/nullish-coalesing
branch
from
2d22f28 to
605a5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Enforce nullish coalescing and optional chaining linting rules.
Why?
They are the default in the
@guardian/eslint-config-typescriptand convey the intent of the logic better.Part of #4935 and #5863