Skip to content

Commit

Permalink
Use the platform.python_implementation because it's the most compat
Browse files Browse the repository at this point in the history
See <pypa/packaging#72 (comment)>
for a discussion of the various setuptools different aliases
support. This means we don't work with 20.2 to 20.6 (released
mid-Feb till late-Mar 2016).
  • Loading branch information
gsnedders committed Apr 23, 2016
1 parent d999875 commit cb58b7c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions requirements-optional.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ charade

# lxml is supported with its own treebuilder ("lxml") and otherwise
# uses the standard ElementTree support
lxml ; platform_python_implementation == 'CPython'
lxml ; platform.python_implementation == 'CPython'

# DATrie can be used in place of our Python trie implementation for
# slightly better parsing performance.
datrie ; platform_python_implementation == 'CPython'
datrie ; platform.python_implementation == 'CPython'

# Can be used to force attributes to be serialized in alphabetical
# order.
Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@

# A conditional extra will only install these items when the extra is
# requested and the condition matches.
"datrie:platform_python_implementation == 'CPython'": ["datrie"],
"lxml:platform_python_implementation == 'CPython'": ["lxml"],
"datrie:platform.python_implementation == 'CPython'": ["datrie"],
"lxml:platform.python_implementation == 'CPython'": ["lxml"],

# Standard extras, will be installed when the extra is requested.
"genshi": ["genshi"],
Expand All @@ -77,6 +77,6 @@
# extra that will be installed whenever the condition matches and the
# all extra is requested.
"all": ["genshi", "charade"],
"all:platform_python_implementation == 'CPython'": ["datrie", "lxml"],
"all:platform.python_implementation == 'CPython'": ["datrie", "lxml"],
},
)

0 comments on commit cb58b7c

Please sign in to comment.