A41 update: Call out precise HeaderMatcher.invert_match semantics #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proper behavior is subtle and easy to assume incorrectly. This caused a bug in Go (grpc/grpc-go#4896) and would be easy for other implementations to assume incorrectly. As determined by Envoy's behavior: https://github.com/envoyproxy/envoy/blob/7d3e444d757696c15a4020b1d2d8ba5cb7f12501/source/common/http/header_utility.cc#L140-L146
ejona86
changed the title
|
@markdroth, friendly ping |
markdroth
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proper behavior is subtle and easy to assume incorrectly. This
caused a bug in Go (grpc/grpc-go#4896) and
would be easy for other implementations to assume incorrectly.
As determined by Envoy's behavior:
https://github.com/envoyproxy/envoy/blob/7d3e444d757696c15a4020b1d2d8ba5cb7f12501/source/common/http/header_utility.cc#L140-L146
CC @YifeiZhuang, @zasweq, @ashithasantosh, @yashykt
This got brought up recently in grpc/grpc#27754, where it was pointed out MetadataMatcher.invert behaves differently. MetadataMatcher.invert was added after this gRFC, so I'm not yet calling out its behavior. But I did see that Go's behavior didn't match the necessary behavior, so let's at least take a baby step and define the behavior of HeaderMatcher.