Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: remove the unnecessary final,static #11098

Merged
merged 3 commits into from
Apr 18, 2024
Merged

minor: remove the unnecessary final,static #11098

merged 3 commits into from
Apr 18, 2024

Conversation

laglangyue
Copy link
Contributor

@laglangyue laglangyue commented Apr 9, 2024 •
edited
Loading

sele expansion

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 9, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 17, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 17, 2024
@ejona86 ejona86 requested a review from sergiitk April 17, 2024 15:52
@sergiitk sergiitk added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 17, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 18, 2024
@laglangyue
Copy link
Contributor Author

Thanks for your review.
Do you think we need just one PR to clean up the diamond for our repository additional?
@ejona86 @sergiitk

@ejona86 ejona86 merged commit 52e65ec into grpc:master Apr 18, 2024
13 checks passed
@ejona86
Copy link
Member

ejona86 commented Apr 23, 2024

@laglangyue, updating examples in a single PR is fine, and can make them feel more modern. But as I said before, I don't think we want to make such changes everywhere because that is a purely stylistic change.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laglangyue @ejona86 @sergiitk @grpc-kokoro