Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.63.0 release notes - jakarta_omit #11081

Closed
panchenko opened this issue Apr 6, 2024 · 3 comments
Closed

1.63.0 release notes - jakarta_omit #11081

panchenko opened this issue Apr 6, 2024 · 3 comments
Assignees
Milestone

Comments

@panchenko
Copy link
Contributor

In the release notes the option is mentioned as JakartaMode=omit, but it should be specified as jakarta_omit.

} else if (options[i].first == "jakarta_omit") {

@panchenko panchenko changed the title 1.63.0 release notes 1.63.0 release notes - jakarta_omit Apr 7, 2024
@panchenko
Copy link
Contributor Author

panchenko commented Apr 8, 2024

The meaning of jakarta_omit is not intuitively clear. Can we change it to

  • generated=javax
  • generated=jakarta
  • generated=omit
    ?

@YifeiZhuang
Copy link
Contributor

I changed the release note to jakarta_omit for a quick fix now.

@YifeiZhuang YifeiZhuang reopened this Apr 9, 2024
@YifeiZhuang YifeiZhuang added this to the Next milestone Apr 9, 2024
@ejona86 ejona86 modified the milestones: Next, 1.64 Apr 11, 2024
@ejona86
Copy link
Member

ejona86 commented Apr 11, 2024

Let's restrict this issue to just the bad release notes, which are fixed. Discussion about the option name can continue in #11086.

@ejona86 ejona86 closed this as completed Apr 11, 2024
@ejona86 ejona86 modified the milestones: 1.64, 1.63 Apr 11, 2024
sergiitk pushed a commit that referenced this issue Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants