docs: fix and improve anti-patterns.md #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous sentence was a bit confusing since `State` does not exist. I think it was a typo for `GetState` or `Connect`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7418 +/- ##
==========================================
- Coverage 81.46% 81.39% -0.08%
==========================================
Files 350 350
Lines 26846 26846
==========================================
- Hits 21871 21850 -21
- Misses 3786 3797 +11
- Partials 1189 1199 +10 |
aranjans
approved these changes
Jul 22, 2024
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous sentence was a bit confusing since
Statedoes not exist. I think it was a typo forGetStateorConnect.RELEASE NOTES: None