stats/opentelemetry: CSM Observability server side component changes #7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
May 24, 2024
dfawley
reviewed
May 28, 2024
| } | ||
| err := handler(srv, als) | ||
| if err != nil { | ||
| logger.Infof("RPC failed with error: %v", err) |
There was a problem hiding this comment.
Remove this log, too, please.
I don't see why we would want to log when an RPC fails in the otel plugin. It's not really a significant event, and could become extremely spammy. If you need it for debugging then you can V(2) it.
https://github.com/grpc/grpc-go/blob/master/Documentation/log_levels.md#info
At verbosity of 0 (the default), any single info message should not be output more than once every 5 minutes under normal operation.
There was a problem hiding this comment.
Ok I had this since every? most? interceptors I saw in the code base had this.
There was a problem hiding this comment.
There was a problem hiding this comment.
Examples are not library code, though, so that is fine.
dfawley
reviewed
May 29, 2024
dfawley
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: N/A