Revert "alts: Queue ALTS handshakes once limit is reached rather than dropping." #6903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6903 +/- ##
==========================================
+ Coverage 83.66% 83.74% +0.08%
==========================================
Files 286 286
Lines 30756 30756
==========================================
+ Hits 25733 25758 +25
+ Misses 3959 3942 -17
+ Partials 1064 1056 -8
|
easwars
approved these changes
Dec 28, 2023
This was referenced Jan 2, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6884, due to flakiness introduced in the e2e tests (#6890). I think (but am not 100% sure) that these failures are due to the test setup, but reverting the PR to be safe while I investigate.
RELEASE NOTES: none