Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/cdsbalancer: stop handling subconn state updates #6509

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 7, 2023

Because its child, clusterresolver, uses StateListener always (

if opts.StateListener == nil {
// If already set, just allow updates to be sent directly to the
// child's listener. Otherwise, we are responsible for forwarding the
// update we'll receive to the proper child.
opts.StateListener = func(state balancer.SubConnState) { c.b.UpdateSubConnState(sc, state) }
}
), this change is safe to make in isolation now.

RELEASE NOTES: none

@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Aug 7, 2023
@dfawley dfawley added this to the 1.58 Release milestone Aug 7, 2023
@dfawley dfawley requested a review from easwars August 7, 2023 21:19
@easwars easwars assigned dfawley and unassigned easwars Aug 7, 2023
@dfawley dfawley merged commit 9c46304 into grpc:master Aug 7, 2023
1 check passed
@dfawley dfawley deleted the updatescs_cds branch August 7, 2023 21:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants