Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: balancer/xds go1.12 only #2748

Merged
merged 2 commits into from
Apr 5, 2019
Merged

internal: balancer/xds go1.12 only #2748

merged 2 commits into from
Apr 5, 2019

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Apr 5, 2019

@menghanl menghanl requested a review from dfawley April 5, 2019 17:44
dfawley
dfawley reviewed Apr 5, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't help our users, unfortunately, who may be on 1.12 but not using modules. But it's probably better than the current state at least?

balancer/balancer.go Outdated
@@ -1,3 +1,5 @@
// +build go1.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

The failures are blocking all of the PRs. This will at least solve that.

@menghanl menghanl merged commit b03f6fd into grpc:master Apr 5, 2019
@menghanl menghanl deleted the nWX branch April 5, 2019 20:51
@menghanl menghanl mentioned this pull request May 24, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @dfawley