Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version to 2.70.0 #2610

Merged
merged 3 commits into from
Mar 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/version.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>

<!-- package version of grpc-dotnet -->
<GrpcDotnetVersion>2.70.0-pre1</GrpcDotnetVersion>
<GrpcDotnetVersion>2.70.0</GrpcDotnetVersion>

<!-- assembly version of grpc-dotnet -->
<GrpcDotnetAssemblyVersion>2.0.0.0</GrpcDotnetAssemblyVersion>
Expand Down
1 change: 0 additions & 1 deletion nuget.config
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<packageSources>
<clear />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
<add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" />
<add key="dotnet7" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json" />
<add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />
<add key="dotnet9" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
Expand Down
2 changes: 1 addition & 1 deletion src/Grpc.Core.Api/VersionInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@ public static class VersionInfo
/// <summary>
/// Current version of gRPC C#
/// </summary>
public const string CurrentVersion = "2.70.0-pre1";
public const string CurrentVersion = "2.70.0";
}
14 changes: 11 additions & 3 deletions test/Shared/TestResolver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ namespace Grpc.Tests.Shared;

internal class TestResolver : PollingResolver
{
private readonly object _lock;
private readonly Func<Task>? _onRefreshAsync;
private readonly TaskCompletionSource<object?> _hasResolvedTcs;
private readonly ILogger _logger;
Expand All @@ -45,6 +46,7 @@ public TestResolver(ILoggerFactory loggerFactory) : this(loggerFactory, null)

public TestResolver(ILoggerFactory? loggerFactory = null, Func<Task>? onRefreshAsync = null) : base(loggerFactory ?? NullLoggerFactory.Instance)
{
_lock = new object();
_onRefreshAsync = onRefreshAsync;
_hasResolvedTcs = new TaskCompletionSource<object?>(TaskCreationOptions.RunContinuationsAsynchronously);
_logger = (ILogger?)loggerFactory?.CreateLogger<TestResolver>() ?? NullLogger.Instance;
Expand All @@ -64,8 +66,11 @@ public void UpdateError(Status status)

public void UpdateResult(ResolverResult result)
{
_result = result;
Listener?.Invoke(result);
lock (_lock)
{
_result = result;
Listener?.Invoke(result);
}
}

protected override async Task ResolveAsync(CancellationToken cancellationToken)
Expand All @@ -75,7 +80,10 @@ protected override async Task ResolveAsync(CancellationToken cancellationToken)
await _onRefreshAsync();
}

Listener(_result ?? ResolverResult.ForResult(Array.Empty<BalancerAddress>(), serviceConfig: null, serviceConfigStatus: null));
lock (_lock)
{
Listener(_result ?? ResolverResult.ForResult(Array.Empty<BalancerAddress>(), serviceConfig: null, serviceConfigStatus: null));
}
_hasResolvedTcs.TrySetResult(null);
}
}
Expand Down