Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign primary handler before other configuration #2445

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Assign primary handler before other configuration #2445

merged 7 commits into from
Jun 5, 2024
+157 −56

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented May 30, 2024 •
edited
Loading

PrimaryHandler is non-nullable so we shouldn't be setting it to null. This will cause problems when combined with changes in dotnet/runtime#101808

This PR assigns primary handler at the start of config and tracks the initial value to see whether it's changed at post-configure if not valid.

@JamesNK JamesNK mentioned this pull request May 30, 2024
Merged
@JamesNK JamesNK force-pushed the jamesnk/improve-tracking-handler branch from 9b9e5f7 to 3435c1b Compare May 30, 2024 04:08
@CarnaViire
Copy link

Would it be safe for a .NET 6 target to reference 8.0 version of Microsoft.Extensions.Http?

Yes, it's built for .NET Standard 2.0.

CarnaViire
CarnaViire approved these changes Jun 3, 2024
View reviewed changes
Copy link

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amcasey
amcasey approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@JamesNK
Refactor test
Loading
Loading status checks…
bc0cf8e
@JamesNK JamesNK force-pushed the jamesnk/improve-tracking-handler branch from b26abba to bc0cf8e Compare June 5, 2024 00:56
@JamesNK JamesNK changed the title Track factory primary handler without modifying the value Assign primary handler before other configuration Jun 5, 2024
@JamesNK
Fix flaky test
Loading
Loading status checks…
d0518d1
@JamesNK JamesNK merged commit 0ea0112 into grpc:master Jun 5, 2024
5 checks passed
@JamesNK JamesNK deleted the jamesnk/improve-tracking-handler branch June 5, 2024 02:07
oguzhand95 referenced this pull request in cerbos/cerbos-sdk-net Jul 22, 2024
@renovate
chore(deps): Update dependency grpc.net.client to v2.64.0 (#145)
f0b2a55 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [Grpc.Net.Client](https://github.com/grpc/grpc-dotnet) | `2.63.0` ->
`2.64.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Grpc.Net.Client/2.64.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Grpc.Net.Client/2.64.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Grpc.Net.Client/2.63.0/2.64.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Grpc.Net.Client/2.63.0/2.64.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary>

###
[`v2.64.0`](https://github.com/grpc/grpc-dotnet/releases/tag/v2.64.0)

#### What's Changed

- doc: fix typo by [@&#8203;WeihanLi](https://github.com/WeihanLi) in
[https://github.com/grpc/grpc-dotnet/pull/2432](https://github.com/grpc/grpc-dotnet/pull/2432)
- doc: fix typo by [@&#8203;WeihanLi](https://github.com/WeihanLi) in
[https://github.com/grpc/grpc-dotnet/pull/2431](https://github.com/grpc/grpc-dotnet/pull/2431)
- ci: upgrade checkout action version by
[@&#8203;WeihanLi](https://github.com/WeihanLi) in
[https://github.com/grpc/grpc-dotnet/pull/2434](https://github.com/grpc/grpc-dotnet/pull/2434)
- build: configure rollForward in global.json by
[@&#8203;WeihanLi](https://github.com/WeihanLi) in
[https://github.com/grpc/grpc-dotnet/pull/2437](https://github.com/grpc/grpc-dotnet/pull/2437)
- Support some HttpClientAction settings and log debug message instead
of an error by [@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2448](https://github.com/grpc/grpc-dotnet/pull/2448)
- Assign primary handler before other configuration by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2445](https://github.com/grpc/grpc-dotnet/pull/2445)
- Update various package versions by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2453](https://github.com/grpc/grpc-dotnet/pull/2453)
- Update Grpc.Tools to 2.64.0 by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2456](https://github.com/grpc/grpc-dotnet/pull/2456)
- Change functional tests to use dynamic ports by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2458](https://github.com/grpc/grpc-dotnet/pull/2458)
- Add WriteResponseHeadersAsync test by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2452](https://github.com/grpc/grpc-dotnet/pull/2452)
- Update repo for .NET 9 by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2457](https://github.com/grpc/grpc-dotnet/pull/2457)
- Fix flaky ConnectTimeout_MultipleCalls_AttemptReconnect test by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2460](https://github.com/grpc/grpc-dotnet/pull/2460)
- Bump branch version to 2.64.0-pre1 by
[@&#8203;stanley-cheung](https://github.com/stanley-cheung) in
[https://github.com/grpc/grpc-dotnet/pull/2471](https://github.com/grpc/grpc-dotnet/pull/2471)
- \[2.64.x] Update Native.DetectWindowsVersion() to consider Windows
Server 2019 to be Window Server by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2473](https://github.com/grpc/grpc-dotnet/pull/2473)
- Bump version to 2.64.0 by
[@&#8203;stanley-cheung](https://github.com/stanley-cheung) in
[https://github.com/grpc/grpc-dotnet/pull/2487](https://github.com/grpc/grpc-dotnet/pull/2487)

**Full Changelog**:
grpc/grpc-dotnet@v2.63.0...v2.64.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos-sdk-net).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2NpIiwiYm90cyIsImtpbmQvY2hvcmUiXX0=-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarnaViire CarnaViire

@amcasey amcasey

@mgravell mgravell

@ReubenBond ReubenBond

@BrennanConroy BrennanConroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamesNK @CarnaViire @amcasey