Change demo exp. to have single goal metric #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahdriel
reviewed
Jan 10, 2025
| @@ -289,7 +290,9 @@ spacing and headings.`, | |||
| owner: ASSET_OWNER, | |||
| datasource: datasource.id, | |||
| project: project.id, | |||
| goalMetrics: metrics | |||
| goalMetrics: metrics.slice(0, 1).map((m) => m.id), | |||
There was a problem hiding this comment.
oh this is actually quite easy to do as you said 😂 -- nice!
There was a problem hiding this comment.
The first one made sense as the goal, and this was the simplest way to do it.
ahdriel
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
To be more in line with our recommendations now that we have secondary metrics, this changes our demo experiment to have only 1 goal metric.
Dependencies
Testing
Screenshots
Adding the sample experiment works fine, runs well, and has the right metrics in the right place.