Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let metrics tag filter show all potential metric tags in project #3479

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

lukesonnet
Copy link
Collaborator

@lukesonnet lukesonnet commented Dec 26, 2024

Features and Changes

Dependencies

Testing

Screenshots

Screenshot 2024-12-26 at 9 05 36 AM Screenshot 2024-12-26 at 9 05 39 AM

Copy link
Member

@jdorn jdorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the tag list to be filtered to just the metrics that match the search term entered. The bug here is that it is only looking at the first page. A better solution would be to have the useSearch hook return both the paginated list as well as an unpaginated list.

@lukesonnet
Copy link
Collaborator Author

lukesonnet commented Dec 26, 2024

A better solution would be to have the useSearch hook return both the paginated list as well as an unpaginated list.

I had that solution before but opted for this solution as it fits @Auz's issue solution better: "Allowing to choose from all tags regardless of if they have metrics tagged with them is probably the best solution."

@lukesonnet
Copy link
Collaborator Author

Updated to use filtered items. Works as expected.

@lukesonnet lukesonnet requested a review from jdorn December 26, 2024 15:15
@lukesonnet lukesonnet merged commit 5ef2b1a into main Dec 26, 2024
4 checks passed
@lukesonnet lukesonnet deleted the ls/3460 branch December 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Filter by tags on metrics is limited
3 participants