Remove auto-refresh imports on EAQ save #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Rolls back #749 as it probably resulted in too many queries being run unnecessarily. We will no longer auto-update the imported experiments list when the EAQs change (this was happening even for users that didn't use the import modal, which is the majority of users).
Instead solves the issue of the import modal error message being unclear (#598) by stating that there has been an update to the Datasource and provide clearer information to let the user click "refresh" which does the same refresh that used to auto-run on the [did] page.
Dependencies
Testing
Screenshots
When datasource dateUpdated > import dateUpdated (and there is an error)
If there's an error but datasource dateUpdated is older than run attempt (status quo)
Loom: https://www.loom.com/share/560478a7baae4c77b6b64aca515312e4