-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements for large orgs #2692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your preview environment pr-2692-bttf has been deployed with errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Large orgs with many feature flags, experiments, and/or users can experience long load times for the GrowthBook app.
During investigation, I came up with a few key areas for improvement:
This PR includes a number of fixes for the above, plus some more minor performance issues:
/user
,/organization
, and/subscription/quote
/user/watching
route and return the data as part ofGET /organization
insteadteams
(queried on every request),apikeys
(queried on every page load), andfeatures
(queried on almost every page load)/init
endpoint (called on every page load)TeamModel
,OrganizationModel
,UserModel
,ApiKeyModel
, andWatchModel
to use the native MongoDB driver instead of Mongoose for reading/usage/features
if realtime graphs are not being displayedswr
library and add options to theuseApi
hook to selectively optimize API callsfindOrganizationById
calls in the back-endFuture, Bigger Changes
Potential regressions / breaking changes
API_HOST
), you now may need to do a hard browser refresh to see the changes. Most browsers are smart enough where just refreshing the page will work fine.GET /api/v1/feature-keys
now excludes archived feature flags.GET /api/v1/features
is unchanged and continues to return archived features