Parametrize data-generator, typecheck before run. #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-growthbook
force-pushed
the
romain/parametrize-data-generation
branch
from
8a495b4 to
9d1550c
Compare
romain-growthbook
force-pushed
the
romain/parametrize-data-generation
branch
from
9d1550c to
e2b890c
Compare
lukesonnet
reviewed
Mar 25, 2024
|
Your preview environment pr-2273-bttf has been deployed. Preview environment endpoints are available at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parametrizes the data generation script to be able to set paremeters as CLI arguments.
It also runs the script with the full typescript check, which revealed one weird spot highlighted in the comments.