Update Experimenter & Analyst Permission Doc detail #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docs ready! ✅ Preview Built with commit 64b5386. |
mknowlton89
requested review from
jdorn,
bttf,
lukesonnet,
bryce-fitzsimons,
msamper and
august-growthbook
mknowlton89
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Updates our docs to improve the accuracy around data source permissions for Anaylsts and Experimenters.
Previously, our docs indicated that
ExperimenterandAnalystroles could only view Data sources, but not edit. This is only partially true - they can't edit certain settings like name, description, projects, or connection params, but they can edit the queries associated with metrics (experiment assignments, etc).This update reflects that discrepancy within the docs.
This is due to how the
DataSourceFormsubmits thePUTrequest. It passes in the full data source object, including the connection params. In the future, we can either move the connection params to a different modal, or update thePUTcall to only pass in the updated properties, and add some front-end logic to disable fields a user withoutcreateDatasourcespermissions shouldn't be able to update (connection parameters).Then, we could allow those with
editDataSourceSettingspermissions to edit things like name, description, projects, etc.Link to updated docs page.