-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buyer/seller IDs to CSV fields #302
base: master
Are you sure you want to change the base?
Add buyer/seller IDs to CSV fields #302
Conversation
Previously, the CSV exports used to only contain the names of the trading parties. Including the unique IDs makes it easier to connect CSV rows to the corresponding entities.
Thanks a lot for your contribution and re-adding the buyer and seller ids to the exported CSV files. We will leave our reviews soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 52.58% 52.58%
=======================================
Files 50 50
Lines 3041 3041
Branches 586 586
=======================================
Hits 1599 1599
Misses 1371 1371
Partials 71 71 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for taking the time to review this external PR! Should I update the branch with the newest changes from master? |
Yes, before pushing a PR to master it should be up to date, let us know when you're done so we can perform another round of review |
@Hassan754 Alright, there were no merge conflicts with master. The files I edited remained untouched since my commit. |
Previously, the CSV exports used to only contain the names of the
trading parties. Including the unique IDs makes it easier to connect
CSV rows to the corresponding entities.