Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented support for lu, lu! + SparseMatrixCSR ... #13

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

amartinhuertas
Copy link
Member

@amartinhuertas amartinhuertas commented Oct 6, 2021

@fverdugo I did not yet run Gridap tests. I will let you know when I run them.

Related to #12 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #13 (e6b18d7) into master (0d6a94d) will increase coverage by 1.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   72.81%   73.95%   +1.13%     
==========================================
  Files           3        3              
  Lines         206      215       +9     
==========================================
+ Hits          150      159       +9     
  Misses         56       56              
Impacted Files Coverage Δ
src/SparseMatricesCSR.jl 100.00% <ø> (ø)
src/SparseMatrixCSR.jl 69.59% <100.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6a94d...e6b18d7. Read the comment docs.

@amartinhuertas
Copy link
Member Author

@fverdugo I did not yet run Gridap tests. I will let you know when I run them.

Ok. Tests are now passing. You can accept the PR and register 0.6.3, whenever you can ...

@fverdugo fverdugo merged commit de63e5c into master Oct 6, 2021
@fverdugo fverdugo deleted the adding_lu_to_CSR branch October 6, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants