Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious export and @publish of non-existing fill_cpp_data_raw #85

Merged
merged 1 commit into from
May 20, 2024

Conversation

dnuy
Copy link
Contributor

@dnuy dnuy commented May 20, 2024

The current version breaks during precompile stage as it has a spurious export and @publish of a non-existing method fill_cpp_data_raw. Just removing the two respective lines fixes this.

This was what I grabbed out of a CI build using GridapEmbedded:

ERROR: LoadError: UndefVarError: `fill_cpp_data_raw` not defined
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/GridapEmbedded/r8izR/src/Exports.jl:4
...

@ericneiva ericneiva merged commit 8a036ee into gridap:master May 20, 2024
5 checks passed
@ericneiva
Copy link
Member

Hi, @dnuy, thanks for the fix :)

@dnuy dnuy deleted the remove-non-existing-export branch December 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants