Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FillArrays version to newest versions #65

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

kishore-nori
Copy link
Collaborator

Updated FillArrays version to newest versions 0.12 and 0.13 in Project.toml and bumped up the GridapEmbedded patch version to 0.8.1 as per @amartinhuertas suggestion. This was to resolve some version compatibility issues with other external packages.

@amartinhuertas
Copy link
Member

Thanks for the PR! Let us wait until the tests pass. Then I will accept.

@kishore-nori
Copy link
Collaborator Author

kishore-nori commented Jan 13, 2023

There seems to be another incompatibility

ERROR: Unsatisfiable requirements detected for package PolynomialBases [c74db56a]:
 PolynomialBases [c74db56a] log:
 ├─possible versions are: 0.4.0-0.4.15 or uninstalled
 ├─restricted by compatibility requirements with Gridap [56d4f2e9] to versions: 0.4.12-0.4.15
 │ └─Gridap [56d4f2e9] log:
 │   ├─possible versions are: [0.1.0, 0.2.0, 0.3.0, 0.4.0, 0.5.0-0.5.2, 0.6.0, 0.7.0-0.7.1, 0.8.0, 0.9.0-0.9.2, 0.10.0-0.10.4, 0.11.0-0.11.2, 0.12.0, 0.13.0-0.13.4, 0.14.0-0.14.2, 0.15.0-0.15.5, 0.16.0-0.16.5, 0.17.0-0.17.16] or uninstalled
 │   └─restricted to versions 0.17.13-0.17 by GridapEmbedded [8838a6a3], leaving only versions 0.17.13-0.17.16
 │     └─GridapEmbedded [8838a6a3] log:
 │       ├─possible versions are: 0.8.1 or uninstalled
 │       └─GridapEmbedded [8838a6a3] is fixed to version 0.8.1
 └─restricted by julia compatibility requirements to versions: 0.4.0-0.4.10 or uninstalled — no versions left

probably because the julia version is set to 1.3 here!

@amartinhuertas
Copy link
Member

probably because the julia version is set to 1.3 here!

To 1.5 in one of the ci files. Let me bump it.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #65 (3113de5) into master (dd2cb69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   81.66%   81.66%           
=======================================
  Files          16       16           
  Lines        1909     1909           
=======================================
  Hits         1559     1559           
  Misses        350      350           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amartinhuertas amartinhuertas merged commit 1b463fd into master Jan 13, 2023
@kishore-nori kishore-nori deleted the change-fillarrays-version branch January 13, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants