Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed jacobian for general test basis where dim not same as trial for Skeleton integration terms #815

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

kishore-nori
Copy link
Collaborator

  • In case of skeleton integration jacobian, earlier code assumed that the cell wise dim of trial and test basis is the same
  • now the code has been rewritten to generalise for case when the above may not be the same
  • relevant tests have passed

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #815 (3925406) into master (702f892) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files         162      162           
  Lines       17993    17993           
=======================================
  Hits        15917    15917           
  Misses       2076     2076           
Impacted Files Coverage Δ
src/FESpaces/FEAutodiff.jl 92.85% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@amartinhuertas amartinhuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kishore-nori ! Thanks for your work. Can you please add an entry to the NEWS.md file?

@kishore-nori
Copy link
Collaborator Author

Hi Alberto, updated the NEWS.md file!

@amartinhuertas amartinhuertas merged commit 345a511 into master Jul 22, 2022
@kishore-nori kishore-nori deleted the fix-skeleton-jacobian branch July 26, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants