Pvd functions #736
Merged
Pvd functions #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 88.39% 88.46% +0.07%
==========================================
Files 132 132
Lines 15458 15562 +104
==========================================
+ Hits 13664 13767 +103
- Misses 1794 1795 +1
Continue to review full report at Codecov.
|
fverdugo
requested changes
Jan 20, 2022
src/Visualization/Vtk.jl
Outdated
| end | ||
| end | ||
|
|
||
| function createpvd(f::Function,parts::Nothing,args...;kwargs...) |
There was a problem hiding this comment.
I think that this one is redundant. Previous function already does the job for this case, right?
There was a problem hiding this comment.
Even better: keep this function but remove ::Function so that one cas use other types of callable objects.
There was a problem hiding this comment.
I have quick-fixed this myself.
fverdugo
approved these changes
Jan 20, 2022
fverdugo
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gridap functions that wrap
paraview_collectionto allow a common API withGridapDistributed